Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add vercel as OAuth provider #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolfand merged 1 commit into from
Dec 15, 2025
Merged

Add vercel as OAuth provider #425

swolfand merged 1 commit into from
Dec 15, 2025

Conversation

@swolfand
Copy link
Collaborator

@swolfand swolfand commented Dec 15, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

This pull request adds support for the Vercel OAuth provider to the OAuthProvider enum and its related documentation and logic. The main changes include updating the documentation, adding the new enum value, and handling Vercel in the provider data mapping.

OAuth provider support:

  • Updated the documentation in OAuthProvider.kt to list Vercel as a supported developer platform.
  • Added VERCEL as a new value in the OAuthProvider enum.
  • Updated the toProviderData() method to handle the new VERCEL provider, returning the appropriate OAuthProviderData.

Summary by CodeRabbit

  • New Features
    • Vercel is now available as an OAuth authentication provider. Users can sign in using their Vercel accounts alongside other supported authentication methods.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

📝 Walkthrough

Walkthrough

A new VERCEL OAuth provider was added to the OAuthProvider enum in the Kotlin API module. The implementation includes a provider data mapping entry configuring Vercel with provider identifier "vercel", strategy "oauth_vercel", and display name "Vercel". The change enables the fromStrategy method to recognize and convert the "oauth_vercel" strategy string into the OAuthProvider.VERCEL enum value. The documentation header was updated to reflect Vercel as a supported developer platform.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding Vercel as an OAuth provider, which matches the actual code changes.
Description check ✅ Passed The description follows the template structure with a 'Summary of changes' section and clearly explains the changes made to support Vercel OAuth provider.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2eb860e and 1cf8e5d.

📒 Files selected for processing (1)
  • source/api/src/main/kotlin/com/clerk/api/sso/OAuthProvider.kt (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • source/api/src/main/kotlin/com/clerk/api/sso/OAuthProvider.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: test-module (:source:api, source/api, source-api)
  • GitHub Check: verify
  • GitHub Check: test-module (:source:ui, source/ui, source-ui)
  • GitHub Check: build-module (:source:ui)
  • GitHub Check: build-module (:source:api)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
source/api/src/main/kotlin/com/clerk/api/sso/OAuthProvider.kt (1)

17-17: Implementation looks correct.

The VERCEL provider follows the established pattern correctly. Consider adding tests to verify the new provider (e.g., enum existence, providerData values, and fromStrategy("oauth_vercel") resolution).

Also applies to: 120-121, 241-241

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swolfand swolfand merged commit 913763b into main Dec 15, 2025
10 checks passed
@swolfand swolfand deleted the sam/mobile-364-android-add-vercel-as-oauth-type branch December 15, 2025 18:34
swolfand added a commit that referenced this pull request Dec 18, 2025
@swolfand
add vercel as OAuth provider (#425)
a88c9fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swolfand