Pre-built components #165
Pre-built components #165
Conversation
0e8c550 to
f21f6eb
Compare
f7a765e to
b2496fd
Compare
d68c066 to
e836392
Compare
463cf8b to
0cb3c04
Compare
* Add SecuredByClerkView and spacing to profile scaffold Co-authored-by: sam <[email protected]> * update snapshots --------- Co-authored-by: Cursor Agent <[email protected]>
|
❌ Paparazzi found snapshot diffs.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val emailIsEnabled: Boolean | ||
| get() = | ||
| (testEnabledFirstFactorAttributes ?: Clerk.enabledFirstFactorAttributes).contains( | ||
| EMAIL_ADDRESS | ||
| ) | ||
|
|
||
| val usernameIsEnabled: Boolean | ||
| get() = | ||
| (testEnabledFirstFactorAttributes ?: Clerk.enabledFirstFactorAttributes).contains(USERNAME) |
There was a problem hiding this comment.
Add Clerk.enabledFirstFactorAttributes or stop using it
The new AuthStartViewHelper reads Clerk.enabledFirstFactorAttributes to decide which identifiers are available, but Clerk exposes no such property (see Clerk.kt, which still only provides flags like passwordIsEnabled). With no definition anywhere in the project, this code will not compile and the UI module cannot build. Either expose the list on Clerk or avoid calling it here.
Useful? React with 👍 / 👎.
| @Composable | ||
| fun OrganizationAvatar( | ||
| modifier: Modifier = Modifier, | ||
| shape: Shape? = null, | ||
| size: AvatarSize = AvatarSize.MEDIUM, | ||
| clerkTheme: ClerkTheme? = null, | ||
| ) { | ||
| val url = Clerk.organizationLogoUrl | ||
| ClerkMaterialTheme(clerkTheme = clerkTheme) { | ||
| AvatarView( | ||
| imageUrl = url, | ||
| size = size, |
There was a problem hiding this comment.
Provide organizationLogoUrl before using it
OrganizationAvatar now calls Clerk.organizationLogoUrl, but the Clerk SDK still only exposes logoUrl—there is no organizationLogoUrl property anywhere in Clerk.kt or the API module. This unresolved reference will prevent the UI module and tests from compiling until the property is added or the call is reverted to the existing logo field.
Useful? React with 👍 / 👎.
|
❌ Paparazzi found snapshot diffs.
|
5 similar comments
|
❌ Paparazzi found snapshot diffs.
|
|
❌ Paparazzi found snapshot diffs.
|
|
❌ Paparazzi found snapshot diffs.
|
|
❌ Paparazzi found snapshot diffs.
|
|
❌ Paparazzi found snapshot diffs.
|
97303e9 to
6481d76
Compare
Draft PR for pre-built components.
Note: this isn't getting merged until it's completely done since we don't want upstream consumers of the API SDK to get ui components before they're ready