Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mike/mobile-336-android-add-legalaccepted-to-signup-params #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolfand merged 2 commits into from
Nov 30, 2025
Merged

mike/mobile-336-android-add-legalaccepted-to-signup-params #392

swolfand merged 2 commits into from
Nov 30, 2025

Conversation

@mikepitre
Copy link
Contributor

@mikepitre mikepitre commented Nov 25, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features
    • Added support for capturing legal acceptance status during sign-up creation and updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@mikepitre mikepitre requested a review from swolfand November 25, 2025 17:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request adds an optional legalAccepted parameter to the SignUp API. This parameter is introduced in two parameter data classes: SignUp.CreateParams.Standard and SignUp.SignUpUpdateParams.Standard. The field is serialized as "legal_accepted" in the API payload and defaults to null. Documentation comments were updated to reflect this addition in the public API signatures.

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing. Only a template header is present with no actual content describing the changes. Add a detailed pull request description explaining what the legalAccepted parameter does, why it's needed, and how it affects the sign-up flow for both create and update operations.
Title check ❓ Inconclusive The PR title is a branch name rather than a descriptive summary. While it references the change (adding legal_accepted to signup params), it uses a technical branch naming convention that doesn't clearly communicate the main change to reviewers. Consider using a clearer title like 'Add legal_accepted field to SignUp create and update parameters' that better summarizes the change for history and clarity.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mikepitre mikepitre changed the title Mike/add legal accepted param to sign up mike/mobile-336-android-add-legalaccepted-to-signup-params Nov 25, 2025
@swolfand swolfand merged commit 88a5594 into main Nov 30, 2025
9 checks passed
@swolfand swolfand deleted the mike/add-legal-accepted-param-to-sign-up branch November 30, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swolfand swolfand swolfand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikepitre @swolfand @cursoragent