Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thiskevinwang
Copy link
Member

@thiskevinwang thiskevinwang commented Jul 31, 2024

Description

This adds a new page for our Cognito password migrator

Preview page @ https://clerk.com/docs/pr/1345/deployments/migrate-from-cognito

This unblocks the changelog entry in https://github.com/clerk/clerk/pull/532

@thiskevinwang thiskevinwang force-pushed the kevin/user-501-create-how-to-use-document branch from 4a1d420 to 9a03f01 Compare July 31, 2024 13:46
@thiskevinwang thiskevinwang changed the title kevin/user 501 create how to use document feat(guides): Cognito password migrator Jul 31, 2024
@thiskevinwang thiskevinwang marked this pull request as ready for review July 31, 2024 13:46
@thiskevinwang thiskevinwang requested a review from a team as a code owner July 31, 2024 13:47
@github-actions
Copy link
Contributor

Hey, here’s your docs preview: https://clerk.com/docs/pr/1345

@colinclerk
Copy link
Member

  • Use @clerk/backend instead of @clerk/clerk-sdk-node. sdk-node is just a re-export of backend, but we've kept it around for backward compat reasons. The code is all isomorphic for cross-runtime compat, though, so we prefer backend for guides going forward.
  • I don't think I understand the "Caution" callout. I would expect guidance on setting this for my existing user pool instead of a link to create a new user pool.

@kylemac
Copy link
Contributor

kylemac commented Jul 31, 2024

i think the right idea is to move this from "guides" and put it the "deployments and migrations -> migrations" section

@thiskevinwang
Copy link
Member Author

thiskevinwang commented Jul 31, 2024

  • Use @clerk/backend instead of @clerk/clerk-sdk-node. sdk-node is just a re-export of backend, but we've kept it around for backward compat reasons. The code is all isomorphic for cross-runtime compat, though, so we prefer backend for guides going forward.
  • I don't think I understand the "Caution" callout. I would expect guidance on setting this for my existing user pool instead of a link to create a new user pool.

@colinclerk

  1. Good suggestion, I'll update to use @clerk/backend
  2. The caution callout mentions that you can create a new client for your user pool. This is not to be confused with the user pool itself. Do you think this is misleading and should be removed? Or should we keep it and reword to be less confusing?

Edit updated the word to be less confusing

@thiskevinwang
Copy link
Member Author

i think the right idea is to move this from "guides" and put it the "deployments and migrations -> migrations" section

@kylemac done. The page is now at /docs/deployments/cognito-password-migrator

CleanShot 2024-07-31 at 16 24 26@2x

@kylemac
Copy link
Contributor

kylemac commented Jul 31, 2024

How about just generically "migrate from Cognito" and then inside there we share about the migrator feature

@thiskevinwang
Copy link
Member Author

How about just generically "migrate from Cognito" and then inside there we share about the migrator feature

@kylemac Sounds good to me. That should be an easy title + slug change. The document is pretty un-opinionated w.r.t it being about Migrating from Cognito vs. the password migrator feature. 👍

@thiskevinwang thiskevinwang changed the title feat(guides): Cognito password migrator feat(deployments): Migrate from Cognito Jul 31, 2024
@thiskevinwang thiskevinwang force-pushed the kevin/user-501-create-how-to-use-document branch from 32dbef3 to 39489e4 Compare August 1, 2024 18:46
@thiskevinwang thiskevinwang merged commit 5f5db97 into main Aug 2, 2024
@thiskevinwang thiskevinwang deleted the kevin/user-501-create-how-to-use-document branch August 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants