Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(release): discussion category with assets #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2022
Merged

fix(release): discussion category with assets #5019

merged 4 commits into from
Feb 15, 2022

Conversation

@k-jun
Copy link

@k-jun k-jun commented Jan 10, 2022 •
edited
Loading

Description

Fixes #4993

when --discussion-category and additional assets are given at the same time, the created release doesn't contain the specified discussion.

$ gh release create abc/1.2.3-rc2 --discussion-category "Announcements" --generate-notes hello.txt

there are two reasons for causing this bug.

  • the assets uploading process is creating draft release, uploading, and publish the release.
  • discussion-category doesn't included in draft release.

in the draft creation phase, discussion_category_name is attached to the body but it is invalid 'cause the second reason.
in the publish phase, --discussion-category is not included, so that the --discussion-category setting isn't applied to the created release.

Changes

To fix that, I just add discussion_category_name value in the publish release api's body.

@k-jun k-jun marked this pull request as ready for review January 10, 2022 17:44
@k-jun k-jun requested a review from a team as a code owner January 10, 2022 17:44
@k-jun k-jun requested review from vilmibm and removed request for a team January 10, 2022 17:44
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 10, 2022
vilmibm
vilmibm previously requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good start, but I'd like to see two things: 1) a typed struct passed to publishRelease instead of a map and 2) tests

mislav
mislav approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vilm I've addressed the code review so this can be merged.

@mislav mislav enabled auto-merge February 15, 2022 17:35
@mislav mislav merged commit 95b1e7f into cli:trunk Feb 15, 2022
@renovate renovate bot mentioned this pull request Aug 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mislav mislav mislav approved these changes

@vilmibm vilmibm vilmibm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vilmibm vilmibm

Labels

external pull request originating outside of the CLI core team needs-user-input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using discussion-category and uploading files is incompatible in gh release create

4 participants

@k-jun @mislav @vilmibm @cliAutomation