Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix make site-docs #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix make site-docs #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test:
.PHONY: test

site:
git worktree add site gh-pages
git clone https://github.com/github/cli.github.com.git "$@"

site-docs: site
git -C site pull
Expand All @@ -33,5 +33,4 @@ site-docs: site
rm -f site/manual/*.bak
git -C site add 'manual/gh*.md'
git -C site commit -m 'update help docs'
git -C site push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm confused why we'd commit and not push?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly because a separate commit will be needed to bump the version number in site/index.html on release. Pushing before that would rebuild the site with new docs but with old version number referenced on the home page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right.

.PHONY: site-docs
2 changes: 1 addition & 1 deletion cmd/gen-docs/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func main() {

func filePrepender(filename string) string {
return `---
layout: page
layout: manual
permalink: /:path/:basename
---

Expand Down