Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove duplicated PRs from GitHub API response. #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2020
Merged

Remove duplicated PRs from GitHub API response. #594

merged 4 commits into from
Mar 5, 2020

Conversation

@alissonbrunosa
Copy link
Contributor

Fixes #592

mislav
mislav suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the fix! This looks good, but I think extra precaution needs to be taken for this workaround to play well with limiting and pagination.

@alissonbrunosa alissonbrunosa force-pushed the pr-list-remove-duplicates branch from a701bc4 to 101d985 Compare March 5, 2020 17:10
mislav
mislav reviewed Mar 5, 2020
View reviewed changes
mislav
mislav approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you 🙇

@mislav mislav merged commit ca7a936 into cli:master Mar 5, 2020
@alissonbrunosa alissonbrunosa deleted the pr-list-remove-duplicates branch March 5, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pr list command with multiple labels shows duplicated PR

2 participants

@alissonbrunosa @mislav