Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't list remotes when --repo flag is set #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

Don't list remotes when --repo flag is set #656

merged 2 commits into from
Mar 18, 2020

Conversation

@dsseng
Copy link
Contributor

@dsseng dsseng commented Mar 14, 2020 •
edited by mislav
Loading

Summary

Ref. #339

@billygriffin
Copy link
Contributor

Should this be "Fixes #339" now?

@dsseng
Copy link
Contributor Author

dsseng commented Mar 16, 2020

@billygriffin good catch. Thank you.

mislav
mislav suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the fix looks good; thank you! I have an idea how to make the changeset even smaller, but keep the same fix.

@dsseng dsseng requested a review from mislav March 17, 2020 17:06
mislav
mislav approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you for following up

@mislav mislav merged commit e80c2f8 into cli:master Mar 18, 2020
@mislav
Copy link
Contributor

mislav commented Mar 18, 2020

This only partially fixes #339, so I've only referenced it from this PR but changed it to not have it auto-close. I'm making an additional fix to address pr status specifically for #339

@dsseng dsseng deleted the fix-repo-not-found branch March 18, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsseng @billygriffin @mislav