Thanks to visit codestin.com
Credit goes to github.com

Skip to content

error instead of prompt for unset base repo #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2022
Merged

error instead of prompt for unset base repo #6738

merged 1 commit into from
Dec 19, 2022

Conversation

@vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Dec 15, 2022

This PR:

  • Removes the prompt from BaseRepo about base repositories, instructing users to use gh repo set-default
  • adds --unset to gh repo set-default primarily for my own comfort
  • updates BaseRepo call sites to not wrap errors as I added more error context within BaseRepo
  • fixes some small issues with gh config base a way to configure the base repo #4859

@vilmibm vilmibm requested a review from a team as a code owner December 15, 2022 19:49
@vilmibm vilmibm requested review from samcoe and removed request for a team December 15, 2022 19:49
mislav
mislav approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@mislav mislav merged commit 6d93849 into trunk Dec 19, 2022
@mislav mislav deleted the default-repo-error branch December 19, 2022 14:53
This was referenced Dec 22, 2022
Closed
Closed
@williammartin williammartin mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samcoe samcoe Awaiting requested review from samcoe samcoe is a code owner automatically assigned from cli/code-reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vilmibm vilmibm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vilmibm @mislav