Respect base repository when passing URL argument to pr checkout/view
#687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the repository owner+name component of the URL was ignored and only the pull request number was read. Now, the URL dictates which base repository will be used.
vilmibm
approved these changes
Mar 20, 2020
| restoreCmd := utils.SetPrepareCmd(func(cmd *exec.Cmd) utils.Runnable { | ||
| switch strings.Join(cmd.Args, " ") { | ||
| case "git show-ref --verify --quiet refs/heads/feature": | ||
| return &errorStub{"exit status: 1"} |
There was a problem hiding this comment.
this reminds me i'd like to add the ability to stub errors in the CmdStubber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the repository owner+name component of the URL was ignored and only the pull request number was read. Now, the URL dictates which base repository will be used.
Bonus fixes:
--repoargument is now respected forpr checkoutAllow specifying a remote for PR checkout #633 (comment);pr checkoutfrom within a fork is now supported, i.e. queries the parent repo accordingly.Fixes #408