Add ability to view repo in terminal and do it by default #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13e1543 to
3459dfa
Compare
mislav
suggested changes
Mar 23, 2020
mislav
approved these changes
Mar 25, 2020
command/repo.go
Outdated
| openURL := fmt.Sprintf("https://github.com/%s", ghrepo.FullName(toView)) | ||
| fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", displayURL(openURL)) | ||
| return utils.OpenInBrowser(openURL) | ||
| readmeContent, err := api.RepositoryReadme(apiClient, fullName) |
There was a problem hiding this comment.
Nit: if err is not explicitly handled here, we should assign the error to _ instead to signal that we're intentionally discarding the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
repo viewto default to terminal output. Adds-w/--webto suport previous behavior.(...snip...)
blank repo:
closes #623
Details
I included only the metadata suggested in #623: full name, description, readme, and url. If a readme is detecting as being not-markdown, it's rendered as plain text. A blank readme is rendered the same as no readme ("No README provided").
Test changes
I added a helper called
ExpectLinesto our test helpers. I noticed we were copying a pasting a tonof lines for checking a list of regexes against captured STDOUT and was able to get rid of ~60 lines
from the test suite.