Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support ext install --force #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mislav merged 2 commits into from
Mar 20, 2023
Merged

Support ext install --force #7173

mislav merged 2 commits into from
Mar 20, 2023

Conversation

@heaths
Copy link
Contributor

@heaths heaths commented Mar 15, 2023

Resolves #7096

@heaths heaths requested a review from a team as a code owner March 15, 2023 05:43
@heaths heaths requested review from samcoe and removed request for a team March 15, 2023 05:43
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 15, 2023
@heaths
Copy link
Contributor Author

heaths commented Mar 15, 2023

@mislav @samcoe I considered changing the ExtensionManager to do this install-or-upgrade but after consideration it seemed better to keep the Install and Upgrade functions targeting only those scenarios - that any caller would better decide how to call them based on user input e.g., --force.

mislav
mislav suggested changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is going in the right direction

@heaths heaths mentioned this pull request Mar 17, 2023
Closed
mislav
mislav approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mislav mislav merged commit 88cae9f into cli:trunk Mar 20, 2023
@heaths heaths deleted the issue7096 branch March 20, 2023 16:28
jtpetty pushed a commit that referenced this pull request May 22, 2023
@heaths @jtpetty
Support ext install --force (#7173)
14e82f5 
Resolves #7096
@heaths heaths mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samcoe samcoe Awaiting requested review from samcoe samcoe is a code owner automatically assigned from cli/code-reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mislav mislav

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow forcibly installing an extension

3 participants

@heaths @mislav @cliAutomation