Thanks to visit codestin.com
Credit goes to github.com

Skip to content

variable list: fix api path #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mislav merged 2 commits into from
Mar 21, 2023
Merged

variable list: fix api path #7207

mislav merged 2 commits into from
Mar 21, 2023

Conversation

@rsteube
Copy link
Contributor

@rsteube rsteube commented Mar 21, 2023

Getting a 404 trying to list variables for a specific environment because repositories is used instead of repos:

esh ❯ gh variable list --env github-pages 
failed to get variables: HTTP 404: Not Found (https://api.github.com/repositories/rsteube/carapace-bin/environments/github-pages/variables?per_page=100)
Exception: gh exited with 1
[tty 6]:1:1: gh variable list --env github-pages

related #6995

@rsteube rsteube requested a review from a team as a code owner March 21, 2023 10:19
@rsteube rsteube requested review from vilmibm and removed request for a team March 21, 2023 10:19
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 21, 2023
@rsteube rsteube force-pushed the fix-variable-list branch from 39cc27e to b63f5e0 Compare March 21, 2023 10:30
mislav
mislav approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; thank you!

Pushed an additional fix for variable delete.

@mislav mislav enabled auto-merge (squash) March 21, 2023 11:38
@mislav mislav merged commit 1fc98f6 into cli:trunk Mar 21, 2023
@rsteube rsteube deleted the fix-variable-list branch March 21, 2023 11:47
@behnamkhanioffical

This comment was marked as spam.

Sign in to view
@cklim11 cklim11 mentioned this pull request Mar 24, 2023
Open
@austindgkz

This comment was marked as spam.

Sign in to view
@mhtv24

This comment was marked as spam.

Sign in to view
@mhtv24

This comment was marked as spam.

Sign in to view
jtpetty pushed a commit that referenced this pull request May 22, 2023
@rsteube @mislav @jtpetty
variable: fix listing and deleting variables in an environment (#7207)
26f1754 
Co-authored-by: Mislav Marohnić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vilmibm vilmibm Awaiting requested review from vilmibm vilmibm is a code owner automatically assigned from cli/code-reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rsteube @behnamkhanioffical @austindgkz @mhtv24 @mislav @cliAutomation