Thanks to visit codestin.com
Credit goes to github.com

Skip to content

extend secure storage default to auth refresh #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vilmibm merged 1 commit into from
Apr 4, 2023
Merged

extend secure storage default to auth refresh #7278

vilmibm merged 1 commit into from
Apr 4, 2023

Conversation

@vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Apr 4, 2023 •
edited
Loading

This PR makes gh auth refresh use secure storage by default, requiring --insecure-storage for old plaintext storage behavior.

Note that this means that if you've stored your creds in plaintext intentionally (perhaps because the OS keychain doesn't work for you) running gh auth refresh without --insecure-storage may lead to broken creds.

@vilmibm vilmibm requested a review from a team as a code owner April 4, 2023 22:24
@vilmibm vilmibm requested review from samcoe and removed request for a team April 4, 2023 22:24
@vilmibm vilmibm merged commit 633ca03 into trunk Apr 4, 2023
@vilmibm vilmibm deleted the auth-refresh-storage branch April 4, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vilmibm vilmibm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vilmibm @samcoe