shorthand of clone without username #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm into this. what do you think @ampinsk ? |
|
this makes sense to me! ✨ |
mislav
suggested changes
Jun 2, 2020
command/repo.go
Outdated
| if !strings.Contains(cloneURL, ":") { | ||
| if !strings.Contains(cloneURL, "/") { | ||
| ctx := contextForCommand(cmd) | ||
| currentUsername, err := ctx.AuthLogin() |
There was a problem hiding this comment.
We no longer provide AuthLogin from config: 767521c
Please request CurrentLoginName() in this case. It will result in an additional API request, which you will have to stub in tests for this case. Thank you!
There was a problem hiding this comment.
I fixed this here. Please take a look, thank you!
Signed-off-by: Joe Hattori <[email protected]>
Signed-off-by: Joe Hattori <[email protected]>
mislav
approved these changes
Jun 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #860
Enable the shorthand of cloning private repository by omitting username.