light interactive pr review #885

vilmibm · 2020-05-07T20:59:52Z

This PR adds "light" interactive reviewing; ie still a top-level review but with prompts for review type and adding a body via your editor.

Fixes #434

command/pr_review.go

ampinsk

Yayay I'm excited about this one, it's looking great! ✨ Left some specific comments below :)

ampinsk · 2020-05-08T22:13:30Z

command/pr_review.go

+					"Comment",
+					"Approve",
+					"Request Changes",
+					"Cancel",


Could we nix the Cancel option in the first prompt? I think this muddies up that question and you can cancel by saying no at the submit step.

command/pr_review.go

probablycorey

Just played around with this and it works great. But there was one area that was a bit clunky. If I request changes or want to leave a comment it gives me two choices; edit in editor or skip. But only edit in editor is valid.

But maybe it is a better flow than automatically opening up an editor without explaining to the user why the editor opened?

probablycorey · 2020-05-08T23:58:03Z

command/pr_review.go

 		}
 	}

+	if input == nil {


input confused me a bit here. reivewData, reviewContents might make it more clear.

Also, I realize input wasn't introduced in this PR, so it doesn't have to be changed in this PR.

tierninho · 2020-05-09T00:25:54Z

Do we want affirmation when a user selects Cancel or selects No when the submit prompt is shown? I noticed it isn't present here but we show "Discarding." when a user abandons gh issue create.
If a user does this command gh pr review 13 -b test on their own PR, we should immediately show the failed to create review: Can not approve your own pull request and not wait until the user goes through the steps. Note, we show the error immediately when the -a flag is used.
For both the -c and -r flags, I got "accepts at most 1 arg(s), received 2". Is there any example I can follow?
The user can skip the comment section, but ultimately needs to fill it out else they have to start over. Is this because we cannot easily strip out enter to skip option?
Are we supporting line breaks?
I attempted to use -b but it didn't seen to carry through the the body of the comment or review. Any tips?
An affirmation message would be great if a PR was successfully approved or commented or reviewed.
How is a review different than a comment?

mislav

Works well, but also ran into what @tierninho was describing: the -b flag was ignored unless -a, -r, or -c were passed. Perhaps any flag passed should trigger non-interactive mode and immediately error out on invalid combination of arguments (e.g. -b alone would be invalid).

mislav · 2020-05-11T11:17:39Z

command/pr_review.go

+			return nil, err
+		}
+
+		fmt.Fprintf(out, "Got:\n%s", renderedBody)


Was printing the preview of the review body intended in the final product? We don't do that in issue/pr create, so doing it here looks odd. Also, the user has just seen this text because they've authored it in their text editor, so what would be the intended purpose of printing it out right after?

we've discussed doing it for pr/issue as a review step. I thought this was a good opportunity to try it out.

vilmibm · 2020-05-11T20:50:46Z

@probablycorey I updated GhEditor to support a BlankAllowed property; if set to false, the "enter to skip" behavior is disabled.

vilmibm

radical

vilmibm · 2020-05-11T22:05:36Z

@tierninho

Do we want affirmation when a user selects Cancel or selects No when the submit prompt is shown? I noticed it isn't present here but we show "Discarding." when a user abandons gh issue create.

Good idea, added a discarding message.

If a user does this command gh pr review 13 -b test on their own PR, we should immediately show the failed to create review: Can not approve your own pull request and not wait until the user goes through the steps. Note, we show the error immediately when the -a flag is used.

Fixed.

For both the -c and -r flags, I got "accepts at most 1 arg(s), received 2". Is there any example I can follow?

Can you paste what you ran? sounds like you were missing the -b?

The user can skip the comment section, but ultimately needs to fill it out else they have to start over. Is this because we cannot easily strip out enter to skip option?

Fixed

Are we supporting line breaks?

Yes, but it's markdown-rendered. Two adjacent lines in markdown are joined into one paragraph. A blank line is needed between them.

I attempted to use -b but it didn't seen to carry through the the body of the comment or review. Any tips?

-b is only to be used in conjunction with -a/-c/-r.

An affirmation message would be great if a PR was successfully approved or commented or reviewed.

Fixed

How is a review different than a comment?

They are two separate concepts on github.com.

vilmibm · 2020-05-11T22:08:44Z

I've taken care of all the feedback and none of the new code is very involved so I'm going to go ahead and merge~

tierninho · 2020-05-12T00:23:37Z

Thanks for all the fixes!

Can you paste what you ran? sounds like you were missing the -b?

Yes, I was not including the -b, so we can ignore.

vilmibm changed the title ~~light interactive pr review~~ [WIP] light interactive pr review May 7, 2020

mislav reviewed May 8, 2020

View reviewed changes

command/pr_review.go Outdated Show resolved Hide resolved

vilmibm force-pushed the survey-review branch 2 times, most recently from 79229b8 to f94fc4b Compare May 8, 2020 15:26

vilmibm changed the title ~~[WIP] light interactive pr review~~ light interactive pr review May 8, 2020

vilmibm marked this pull request as ready for review May 8, 2020 18:53

vilmibm requested review from ampinsk, mislav and probablycorey May 8, 2020 19:05

ampinsk reviewed May 8, 2020

View reviewed changes

probablycorey approved these changes May 9, 2020

View reviewed changes

mislav approved these changes May 11, 2020

View reviewed changes

slopwip on interactive review

c8e9768

vilmibm force-pushed the survey-review branch from 15f8679 to 19288f1 Compare May 11, 2020 20:29

vilmibm commented May 11, 2020

View reviewed changes

review feedback

7009321

vilmibm force-pushed the survey-review branch from 036dc4f to 7009321 Compare May 11, 2020 22:06

vilmibm merged commit a7bcfff into master May 11, 2020

mislav deleted the survey-review branch June 25, 2020 14:37

Uh oh!

light interactive pr review #885

light interactive pr review #885

Conversation

vilmibm commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ampinsk left a comment

Choose a reason for hiding this comment

Uh oh!

ampinsk May 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

probablycorey left a comment

Choose a reason for hiding this comment

Uh oh!

probablycorey May 8, 2020

Choose a reason for hiding this comment

Uh oh!

tierninho commented May 9, 2020

Uh oh!

mislav left a comment

Choose a reason for hiding this comment

Uh oh!

mislav May 11, 2020

Choose a reason for hiding this comment

Uh oh!

vilmibm May 11, 2020

Choose a reason for hiding this comment

Uh oh!

vilmibm commented May 11, 2020

Uh oh!

vilmibm left a comment

Choose a reason for hiding this comment

Uh oh!

vilmibm commented May 11, 2020

Uh oh!

vilmibm commented May 11, 2020

Uh oh!

tierninho commented May 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vilmibm commented May 7, 2020 •

edited

Loading