Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dulltz
Copy link
Contributor

@dulltz dulltz commented May 19, 2020

Summary

  • Some short descriptions start with lowercase. Align the first letter to uppercase.
  • Some short descriptions end with period. Align with no period at the end.

Details

$ git rev-parse HEAD
d1bdb31558698541f7e1790cc1a94f187da2585f

$ git grep Short:
command/completion.go:  Short: "Generate shell completion scripts",
command/config.go:      Short: "Set and get gh settings",
command/config.go:      Short: "Prints the value of a given configuration key.",
command/config.go:      Short: "Updates configuration with the value of a given key.",
command/credits.go:     Short: "View project's credits",
command/issue.go:       Short: "Create and view issues",
command/issue.go:       Short: "Create a new issue",
command/issue.go:       Short: "List and filter issues in this repository",
command/issue.go:       Short: "Show status of relevant issues",
command/issue.go:       Short: "View an issue",
command/issue.go:       Short: "close issue",
command/issue.go:       Short: "reopen issue",
command/pr.go:  Short: "Create, view, and checkout pull requests",
command/pr.go:  Short: "List and filter pull requests in this repository",
command/pr.go:  Short: "Show status of relevant pull requests",
command/pr.go:  Short: "View a pull request",
command/pr.go:  Short: "Close a pull request",
command/pr.go:  Short: "Reopen a pull request",
command/pr.go:  Short: "Merge a pull request",
command/pr_checkout.go: Short: "Check out a pull request in Git",
command/pr_create.go:   Short: "Create a pull request",
command/pr_review.go:   Short: "Add a review to a pull request.",
command/repo.go:        Short: "Create, clone, fork, and view repositories",
command/repo.go:        Short: "Clone a repository locally",
command/repo.go:        Short: "Create a new repository",
command/repo.go:        Short: "Create a fork of a repository",
command/repo.go:        Short: "View a repository",
command/root.go:        Short: "GitHub CLI",

- Align the first letter to uppercase.
- Align with no period at the end.
@dulltz dulltz changed the title cosmetic about short descriptions Cosmetic about short descriptions May 19, 2020
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vilmibm vilmibm merged commit 06e43ac into cli:master May 19, 2020
@dulltz dulltz deleted the cosmetic-short branch May 19, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants