Issue/PR Create Interactive Test #986
Conversation
|
@vilmibm I don't think I have the permission to add you as a reviewer |
|
I will add the PR create tests once this is approved, and blank template tests once #950 is merged |
| `)) | ||
|
|
||
| var templateFiles []string | ||
| if rootDir, err := git.ToplevelDir(); err == nil { |
There was a problem hiding this comment.
My hope with template testing is that we're not reading from the filesystem. This can fail or change behavior as we change the repository itself.
I'd rather have a function wrapper around finding templates on the filesystem that can be overriden in tests to provide predictable results.
There was a problem hiding this comment.
Oh. Okay. I was actually thinking that since the code is intended to read from the filesystem and we are also reading from the filesystem in the tests, it should not be a problem. Since changes to the file system would affect the code and the tests in the same way, so they would always be in sync
|
Replaced by #1311 |
Fixes #956