fix: list branches in square brackets in `gh run` and `gh codespace` #10043

uday-rana · 2024-12-08T17:38:17Z

Changes

pkg/cmd/run/shared: Switched parentheses in selectRun() to square brackets.

Before

func selectRun() {
  ...
  fmt.Sprintf("%s %s, %s (%s) %s", ...)
  ...
}

After

func selectRun() {
  ...
  fmt.Sprintf("%s %s, %s [%s] %s", ...)
  ...
}

uday-rana · 2024-12-08T17:56:33Z

hi @BagToad ! I saw this TODO while I was working on this PR and I'd like to work on it if that's okay:

pkg/cmd/run/shared:510 :

// TODO truncate commit message, long ones look terrible
fmt.Sprintf("%s %s, %s [%s] %s", symbol, run.Title(), run.WorkflowName(), run.HeadBranch, preciseAgo(now, run.StartedTime())))

williammartin · 2024-12-09T14:30:12Z

Thanks for opening this, looks like there's some tests that need to be fixed.

With regards your comment on:

// TODO truncate commit message, long ones look terrible

If you're interested in working on it, please create a new issue showing the current behaviour being terrible, and a proposal for what it would look like truncated. We don't accept PRs without issues as per out contribution doc.

Let me know if you need help with the tests. Cheers.

uday-rana · 2024-12-09T17:53:45Z

Sorry about the oversight! I've updated the tests and they're passing locally. I'll look into creating a new issue for the TODO.

uday-rana · 2024-12-10T20:21:55Z

As per #10038 (comment) I've extended the change to gh codespace commands.

BagToad

LGTM @uday-rana - Thanks! ❤️

cmbrose

Looks good for codespaces. Wanted to also call out that we also use branchWithGitStatus() in the cs view command. Not sure if we'd also like to update the formatting there @BagToad

cmbrose · 2024-12-10T22:27:00Z

Oh I didn't notice that this would auto-complete with my review 😅 It's fine in it's current state, we can add on the cs view change if we want in a second PR

BagToad · 2024-12-10T22:29:01Z

@cmbrose No problem! Probably my fault for auto merging it 😅

Thanks for mentioning this! I'll take a look at branchWithGitStatus() and open up a follow-up issue if needed 😁 Could be another good first issue ✨

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.63.2` -> `v2.64.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.64.0`](https://github.com/cli/cli/releases/tag/v2.64.0): GitHub CLI 2.64.0 [Compare Source](cli/cli@v2.63.2...v2.64.0) #### What's Changed - docs: improve docs for browse command as of [#5352](cli/cli#5352) by [@ankddev](https://github.com/ankddev) in cli/cli#10025 - Open MR against gh-merge-base by [@heaths](https://github.com/heaths) in cli/cli#9712 - Add integration tests for `gh attestation verify` when the `bundle-from-oci` flag is specified by [@malancas](https://github.com/malancas) in cli/cli#10020 - `gh repo rename` help text clarifies new repo name should not include owner by [@BagToad](https://github.com/BagToad) in cli/cli#10044 - fix: list branches in square brackets in `gh run` and `gh codespace` by [@uday-rana](https://github.com/uday-rana) in cli/cli#10043 - Bump actions/attest-build-provenance from 1.4.4 to 2.1.0 by [@dependabot](https://github.com/dependabot) in cli/cli#10056 - Bump golang.org/x/crypto from 0.29.0 to 0.31.0 by [@dependabot](https://github.com/dependabot) in cli/cli#10070 - Improve documentation and error messaging for local extension installations without executables by [@BagToad](https://github.com/BagToad) in cli/cli#9933 - docs: better document auth scopes by [@ankddev](https://github.com/ankddev) in cli/cli#10026 - Sigstore verifier logic updates by [@malancas](https://github.com/malancas) in cli/cli#9999 - `gh pr merge --delete-branch` exits with error when merge requested via merge queue by [@BagToad](https://github.com/BagToad) in cli/cli#10074 - sundry `gh at inspect` improvements by [@phillmv](https://github.com/phillmv) in cli/cli#9954 - Support `pr view` for intra-org forks by [@williammartin](https://github.com/williammartin) in cli/cli#10078 - Print policy information before verifying attestations by [@malancas](https://github.com/malancas) in cli/cli#9891 - Improve error handling in apt setup script by [@jobegrabber](https://github.com/jobegrabber) in cli/cli#10055 - Use Windows compatible file name for downloaded attestations when running `gh attestation download` by [@malancas](https://github.com/malancas) in cli/cli#10051 - Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6 by [@dependabot](https://github.com/dependabot) in cli/cli#10094 - Perform all `gh attestation verify` policy options configuration in the `newEnforcementCriteria()` function by [@malancas](https://github.com/malancas) in cli/cli#10012 #### New Contributors - [@ankddev](https://github.com/ankddev) made their first contribution in cli/cli#10025 - [@uday-rana](https://github.com/uday-rana) made their first contribution in cli/cli#10043 - [@jobegrabber](https://github.com/jobegrabber) made their first contribution in cli/cli#10055 **Full Changelog**: cli/cli@v2.63.2...v2.64.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

fix: list branches in square brackets in gh run view (cli#10038)

463105d

uday-rana requested a review from a team as a code owner December 8, 2024 17:38

uday-rana requested a review from BagToad December 8, 2024 17:38

cliAutomation added the external pull request originating outside of the CLI core team label Dec 8, 2024

uday-rana changed the title ~~fix: list branches in square brackets in gh run view (#10038)~~ fix: list branches in square brackets in gh run view Dec 8, 2024

uday-rana changed the title ~~fix: list branches in square brackets in gh run view~~ fix: list branches in square brackets in gh run view Dec 8, 2024

test(gh run): assert branch names are enclosed in square brackets

8afb434

fix: list branches in square brackets in gh codespace

40beb82

uday-rana changed the title ~~fix: list branches in square brackets in gh run view~~ fix: list branches in square brackets in gh run and gh codespace Dec 10, 2024

Merge branch 'trunk' into issue-10038

e8e30da

BagToad requested a review from a team as a code owner December 10, 2024 21:17

BagToad approved these changes Dec 10, 2024

View reviewed changes

BagToad enabled auto-merge December 10, 2024 21:27

cmbrose approved these changes Dec 10, 2024

View reviewed changes

BagToad merged commit 2abe675 into cli:trunk Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: list branches in square brackets in `gh run` and `gh codespace` #10043

fix: list branches in square brackets in `gh run` and `gh codespace` #10043

Uh oh!

uday-rana commented Dec 8, 2024 •

edited

Loading

Uh oh!

uday-rana commented Dec 8, 2024 •

edited

Loading

Uh oh!

williammartin commented Dec 9, 2024

Uh oh!

uday-rana commented Dec 9, 2024

Uh oh!

uday-rana commented Dec 10, 2024

Uh oh!

BagToad left a comment

Uh oh!

cmbrose left a comment

Uh oh!

cmbrose commented Dec 10, 2024

Uh oh!

BagToad commented Dec 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

fix: list branches in square brackets in gh run and gh codespace #10043

fix: list branches in square brackets in gh run and gh codespace #10043

Uh oh!

Conversation

uday-rana commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Before

After

Uh oh!

uday-rana commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williammartin commented Dec 9, 2024

Uh oh!

uday-rana commented Dec 9, 2024

Uh oh!

uday-rana commented Dec 10, 2024

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

cmbrose left a comment

Choose a reason for hiding this comment

Uh oh!

cmbrose commented Dec 10, 2024

Uh oh!

BagToad commented Dec 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: list branches in square brackets in `gh run` and `gh codespace` #10043

fix: list branches in square brackets in `gh run` and `gh codespace` #10043

uday-rana commented Dec 8, 2024 •

edited

Loading

uday-rana commented Dec 8, 2024 •

edited

Loading