Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: gh gist view and gh gist edit prompts with no TTY #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 20, 2025
Merged

Fix: gh gist view and gh gist edit prompts with no TTY #10048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cbaaf77
fixing gh gist view prompts with no TTY
mateusmarquezini Dec 9, 2024
a3cf4e1
Merge branch 'trunk' into fix/issue_10042
mateusmarquezini Dec 9, 2024
b740486
#10042 fixed test
mateusmarquezini Dec 9, 2024
a7dceb3
Merge branch 'fix/issue_10042' of github.com:mateusmarquezini/cli int…
mateusmarquezini Dec 9, 2024
a3a283c
Merge branch 'trunk' into fix/issue_10042
mateusmarquezini Jan 8, 2025
f4f8840
#10042: Add error messages for 'gh gist view/edit' prompts when no TT…
mateusmarquezini Jan 9, 2025
4c2ba56
#10042 removed unnecessary field
mateusmarquezini Jan 9, 2025
f65ac16
Merge branch 'trunk' into fix/issue_10042
mateusmarquezini Jan 12, 2025
c5d6ae6
Update pkg/cmd/gist/edit/edit.go
mateusmarquezini Jan 12, 2025
24e9fed
removed unnecessary space
mateusmarquezini Jan 12, 2025
977e232
#10042: Applied code review suggestions to view_test.go
mateusmarquezini Jan 13, 2025
c0f6eb0
#10042: Attempt to add a new test scenario for handling error message…
mateusmarquezini Jan 13, 2025
4eb0e81
Merge branch 'trunk' into fix/issue_10042
mateusmarquezini Jan 13, 2025
35d81e3
Fix: Gist edit tests for interactivity
BagToad Jan 16, 2025
a2dce58
Merge 'trunk' into fix/issue_10042
BagToad Jan 16, 2025
dec4667
Fix: gist edit/view tests var name consistency
BagToad Jan 16, 2025
5b6fd53
Fix: gist edit test name
BagToad Jan 16, 2025
facd0ca
Fix: accidental whitespace in gist edit
BagToad Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cmd/gist/edit/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ func editRun(opts *EditOptions) error {
if gistID == "" {
cs := opts.IO.ColorScheme()
if gistID == "" {
if !opts.IO.CanPrompt() {
return cmdutil.FlagErrorf("gist ID or URL required when not running interactively")
}

gist, err := shared.PromptGists(opts.Prompter, client, host, cs)
if err != nil {
return err
Expand Down
Loading