Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: gh pr create prioritize --title and --body over --fill when --web is present #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Fix: gh pr create prioritize --title and --body over --fill when --web is present #10547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0358bb2
fix: prioritize title and body over autofill for prs
dankrzeminski32 Mar 6, 2025
98ca86e
fix: prioritize title and body over autofill tests
dankrzeminski32 Mar 6, 2025
a76f7d7
refactor: collapse state conditions
babakks Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions pkg/cmd/pr/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,13 +388,17 @@ func createRun(opts *CreateOptions) error {
return err
}

if opts.TitleProvided {
state.Title = opts.Title
}

if opts.BodyProvided {
state.Body = opts.Body
}

var openURL string

if opts.WebMode {
if !(opts.Autofill || opts.FillFirst) {
state.Title = opts.Title
state.Body = opts.Body
}
if opts.Template != "" {
state.Template = opts.Template
}
Expand All @@ -413,14 +417,6 @@ func createRun(opts *CreateOptions) error {
return previewPR(*opts, openURL)
}

if opts.TitleProvided {
state.Title = opts.Title
}

if opts.BodyProvided {
state.Body = opts.Body
}

existingPR, _, err := opts.Finder.Find(shared.FindOptions{
Selector: ctx.PRRefs.QualifiedHeadRef(),
BaseBranch: ctx.PRRefs.BaseRef(),
Expand Down
22 changes: 22 additions & 0 deletions pkg/cmd/pr/create/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,6 +1590,28 @@ func Test_createRun(t *testing.T) {
},
expectedOut: "https://github.com/OWNER/REPO/pull/12\n",
},
{
name: "web prioritize title and body over fill",
setup: func(opts *CreateOptions, t *testing.T) func() {
opts.WebMode = true
opts.HeadBranch = "feature"
opts.TitleProvided = true
opts.BodyProvided = true
opts.Title = "my title"
opts.Body = "my body"
opts.Autofill = true
return func() {}
},
cmdStubs: func(cs *run.CommandStubber) {
cs.Register(
"git -c log.ShowSignature=false log --pretty=format:%H%x00%s%x00%b%x00 --cherry origin/master...feature",
0,
"56b6f8bb7c9e3a30093cd17e48934ce354148e80\u0000second commit of pr\u0000\u0000\n"+
"3a9b48085046d156c5acce8f3b3a0532cd706a4a\u0000first commit of pr\u0000first commit description\u0000\n",
)
},
expectedBrowse: "https://github.com/OWNER/REPO/compare/master...feature?body=my+body&expand=1&title=my+title",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down