gh api: fix passing file/stdin contents via field arguments #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading from file via `-F [email protected]` syntax would result in `[]byte` Go type, which by default gets serialized to JSON in base64 format, which we don't want here. Traverse all parameters and convert any `[]byte` into `string` before JSON serialization.
vilmibm
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from file via
-F [email protected]syntax would result in[]byteGo type, which by default gets serialized to JSON in base64 format, which we don't want here.Traverse all parameters and convert any
[]byteintostringbefore JSON serialization.Followup to #909