Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bvwells
Copy link
Contributor

@bvwells bvwells commented Jun 10, 2020

Add validation of pr and issue limit command argument to address #1156.

Copy link
Contributor

@probablycorey probablycorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bvwells looks great. I'll leave this open for feedback for a day, and merge it tomorrow if nobody has any issues!

@bvwells
Copy link
Contributor Author

bvwells commented Jun 10, 2020

Thanks for the fast review @probablycorey!

Copy link
Contributor

@AliabbasMerchant AliabbasMerchant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@probablycorey probablycorey merged commit cde7693 into cli:trunk Jun 11, 2020
@bvwells
Copy link
Contributor Author

bvwells commented Jun 11, 2020

Thanks @probablycorey, @AliabbasMerchant and @mislav for the reviews and merge!

@bvwells bvwells deleted the limit branch June 11, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants