Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Jun 10, 2020

Reverts #1124

This is on me; I didn't test pr create locally and turns out this breaks it.

cc @AliabbasMerchant

@AliabbasMerchant
Copy link
Contributor

@vilmibm I had tested it out locally, and it was working. Could you please provide an example where it breaks?

@vilmibm
Copy link
Contributor Author

vilmibm commented Jun 11, 2020

In the cli repo, I created a new branch from trunk and ran pr create both with draft and not draft; in both scenarios I see this behavior:

image

When I revert #1124, it works as expected.

@AliabbasMerchant
Copy link
Contributor

Okay, I will test this locally and get back to you.

@mislav
Copy link
Contributor

mislav commented Jun 11, 2020

@AliabbasMerchant The problem was here:

issueState.Milestones = []string{values.Milestone}

If Milestone was empty, then the slice should be empty as well instead of getting initialized with a blank string.

I could take care of this today in case you don't have time! Just let me know, thank you 🙇

@AliabbasMerchant
Copy link
Contributor

AliabbasMerchant commented Jun 11, 2020

Oh. Right! My mistake. I will fix it.
I thought the Default field would handle that empty string part, but now I realise that it won't be applicable always

@AliabbasMerchant
Copy link
Contributor

Have created #1164 to replace this and fix the error.
@mislav @vilmibm Thanks for your patience. Was busy in office work 😅

@vilmibm vilmibm closed this Jun 11, 2020
@mislav mislav deleted the revert-1124-fix-issue-1083 branch August 3, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants