Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BagToad
Copy link
Member

@BagToad BagToad commented Oct 10, 2025

Fix agent-task create to use smart base repo func to fix bug with resolving upstream repo instead of default repo.

Fixes: #11895

`agent-task` uses smart base repo func to fix bug with resolving upstream instead of local repo.
Copilot AI review requested due to automatic review settings October 10, 2025 16:44
@BagToad BagToad requested a review from a team as a code owner October 10, 2025 16:44
@BagToad BagToad requested a review from babakks October 10, 2025 16:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the gh agent-task create command was incorrectly targeting upstream repositories instead of the default repository. The fix ensures that agent task commands use the smart base repository function for proper repository resolution.

  • Moved agent task command initialization to use the repo-resolving command factory
  • This aligns agent task commands with other commands that require smart repository resolution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I noticed the missing smart base repo today while working on something else.

@BagToad BagToad merged commit 5eb6549 into trunk Oct 10, 2025
13 checks passed
@BagToad BagToad deleted the kw/fix-agent-task-targets-fork branch October 10, 2025 17:12
@0534455145

This comment was marked as spam.

@0534455145

This comment was marked as spam.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 17, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | minor | `v2.81.0` -> `v2.82.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.82.0`](https://github.com/cli/cli/releases/tag/v2.82.0): GitHub CLI 2.82.0

[Compare Source](cli/cli@v2.81.0...v2.82.0)

##### ✨ Features

- `gh pr edit`: Only fetch org teams for reviewers when required by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;11835](cli/cli#11835)

##### πŸ› Fixes

- fix(cache delete): report correct deleted count for key and key+ref deletions by [@&#8203;luxass](https://github.com/luxass) in [#&#8203;11838](cli/cli#11838)
- `gh agent-task create`: Fix `--follow` not killing the progress indicator by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;11879](cli/cli#11879)
- `gh agent-task create`: Fix targetting upstream instead of default repo by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;11896](cli/cli#11896)
- Fix `auth login` and `auth refresh` to use UNIX socket by [@&#8203;babakks](https://github.com/babakks) in [#&#8203;11922](cli/cli#11922)

**Full Changelog**: <cli/cli@v2.81.0...v2.82.0>

</details>

---

### Configuration

πŸ“… **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDguNiIsInVwZGF0ZWRJblZlciI6IjQxLjE0OC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent task creation fails for forks

4 participants