-
Notifications
You must be signed in to change notification settings - Fork 7.7k
gh agent-task create: Fix targetting upstream instead of default repo
#11896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`agent-task` uses smart base repo func to fix bug with resolving upstream instead of local repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the gh agent-task create command was incorrectly targeting upstream repositories instead of the default repository. The fix ensures that agent task commands use the smart base repository function for proper repository resolution.
- Moved agent task command initialization to use the repo-resolving command factory
- This aligns agent task commands with other commands that require smart repository resolution
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
babakks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I noticed the missing smart base repo today while working on something else.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.81.0` -> `v2.82.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.82.0`](https://github.com/cli/cli/releases/tag/v2.82.0): GitHub CLI 2.82.0 [Compare Source](cli/cli@v2.81.0...v2.82.0) ##### β¨ Features - `gh pr edit`: Only fetch org teams for reviewers when required by [@​BagToad](https://github.com/BagToad) in [#​11835](cli/cli#11835) ##### π Fixes - fix(cache delete): report correct deleted count for key and key+ref deletions by [@​luxass](https://github.com/luxass) in [#​11838](cli/cli#11838) - `gh agent-task create`: Fix `--follow` not killing the progress indicator by [@​BagToad](https://github.com/BagToad) in [#​11879](cli/cli#11879) - `gh agent-task create`: Fix targetting upstream instead of default repo by [@​BagToad](https://github.com/BagToad) in [#​11896](cli/cli#11896) - Fix `auth login` and `auth refresh` to use UNIX socket by [@​babakks](https://github.com/babakks) in [#​11922](cli/cli#11922) **Full Changelog**: <cli/cli@v2.81.0...v2.82.0> </details> --- ### Configuration π **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDguNiIsInVwZGF0ZWRJblZlciI6IjQxLjE0OC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Fix
agent-task createto use smart base repo func to fix bug with resolving upstream repo instead of default repo.Fixes: #11895