Replace GraphQL query names with user-friendly progress indicators #12041
+30
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified doQueryWithProgressIndicator to accept separate queryName and label parameters - Updated all query calls to use user-friendly labels: - "UserOrgOwner" -> "owner" - "OrgProjects" -> "organization projects" - "UserProjects" -> "user projects" - "ViewerProjects" -> "projects" - "UserProject", "OrgProject", "ViewerProject" -> "project" - "UserProjectWithItems", etc. -> "project items" - "UserProjectWithFields", etc. -> "project fields" - "ViewerLoginAndOrgs" -> "organizations" - "GetIssueOrPullRequest" -> "issue or pull request" - "Viewer" -> "viewer" - All tests passing Co-authored-by: BagToad <[email protected]>
Copilot
AI
changed the title
[WIP] Fix progress indicator text in project list command
Replace GraphQL query names with user-friendly progress indicators
Oct 28, 2025
Member
|
@copilot Is there really no test files to update for this? If no, can you please explain why not? |
Contributor
Author
No test updates were needed because the tests verify API behavior, not UI text. The change added a second parameter to
The existing tests use gock.New("https://api.github.com").
Post("/graphql").
JSON(map[string]interface{}{
"query": "query UserOrgOwner.*", // Still matches
...
})Since the GraphQL query names remain identical (e.g., "UserOrgOwner", "OrgProjects"), all tests pass without modification. The tests don't assert on progress indicator text - they verify the correct GraphQL queries are sent to the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh project listdisplayed internal GraphQL query names in progress indicators (e.g., "Fetching UserOrgOwner", "Fetching OrgProjects") instead of user-friendly text.Changes
doQueryWithProgressIndicatorto accept separatequeryName(for GraphQL API) andlabel(for user display) parametersUserOrgOwner→ownerOrgProjects→organization projectsUserProjects→user projectsViewerProjectWithItems→project itemsGraphQL query names remain unchanged for API compatibility. Only affects user-visible progress text.
Before:
After:
Original prompt
gh project listshows GraphQL query name when loading instead of user-friendly copy #12040✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.