Closed
Conversation
Member
|
Hey @PvtSec, thanks for looking into this. Our requirements for a feature like this are more substantial than it might seem; we have accessibility obligations to meet, and the maintainers need to spend some time on outlining what the behavior would be for our accessible progress indicator. I recommend subscribing to the connected issue for updates if you're interested in picking this up should the issue ever be labelled with https://github.com/cli/cli/blob/trunk/.github/CONTRIBUTING.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue: #4078
The issue was to display progress of release uploads, which with this PR will be shown as:
$ gh release upload v1.0.0 *.xz ✓ [1/5] Uploaded Release_part_1.xz ✓ [2/5] Uploaded Release_part_2.xz ✓ [3/5] Uploaded Release_part_3.xz ✓ [4/5] Uploaded Release_part_4.xz ⢿ [5/5] Uploading Release_part_5.xz 0% (16 KiB/113 MiB)