Error if go-licenses is not on the PATH #12238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure that the go-licenses tool is available before attempting to use it. The change adds an early check that exits with an error if go-licenses is not found on the PATH, providing clearer feedback when the required tool is missing.
Key Changes:
- Added a verification check for
go-licensesavailability usingcommand -v - Outputs an informative error message and exits if the tool is not found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf6f4ed to
bcb01ed
Compare
babakks
approved these changes
Dec 1, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 12, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | patch | `v2.83.1` -> `v2.83.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.83.2`](https://github.com/cli/cli/releases/tag/v2.83.2): GitHub CLI 2.83.2 [Compare Source](cli/cli@v2.83.1...v2.83.2) #### What's Changed ##### 🐛 Fixes - Isolate user-provided search query from contextual qualifiers by [@​babakks](https://github.com/babakks) in [#​12170](cli/cli#12170) ##### 📚 Docs & Chores - Refactor cfg out of CAPI Client by [@​williammartin](https://github.com/williammartin) in [#​12148](cli/cli#12148) - Remove extra flag default from help usage by [@​andyfeller](https://github.com/andyfeller) in [#​12154](cli/cli#12154) - Add PGP key rotation PoC by [@​babakks](https://github.com/babakks) in [#​12176](cli/cli#12176) - Add Debian/Ubuntu to unofficial packages by [@​andyfeller](https://github.com/andyfeller) in [#​12191](cli/cli#12191) - Error if go-licenses is not on the PATH by [@​williammartin](https://github.com/williammartin) in [#​12238](cli/cli#12238) - refactor: drop multierror in favor of std by [@​ferhatelmas](https://github.com/ferhatelmas) in [#​12234](cli/cli#12234) #####Dependencies - chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.45.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12165](cli/cli#12165) - chore(deps): bump actions/checkout from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12178](cli/cli#12178) - chore(deps): bump google.golang.org/protobuf from 1.36.9 to 1.36.10 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12037](cli/cli#12037) - chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12189](cli/cli#12189) - chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.2.0 to 2.3.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12100](cli/cli#12100) - chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.10 to 1.4.11 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12051](cli/cli#12051) - chore(deps): bump google.golang.org/grpc from 1.75.0 to 1.76.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11972](cli/cli#11972) - chore(deps): bump github.com/charmbracelet/huh from 0.7.0 to 0.8.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11971](cli/cli#11971) - Bump Go to 1.25.4 by [@​github-actions](https://github.com/github-actions)\[bot] in [#​12104](cli/cli#12104) - chore(deps): bump github.com/gdamore/tcell/v2 from 2.9.0 to 2.13.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12246](cli/cli#12246) - chore(deps): bump github.com/hashicorp/go-version from 1.7.0 to 1.8.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12247](cli/cli#12247) - chore(deps): bump github.com/google/go-containerregistry from 0.20.6 to 0.20.7 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​12245](cli/cli#12245) - Bump Go to 1.25.5 by [@​github-actions](https://github.com/github-actions)\[bot] in [#​12250](cli/cli#12250) - Bump dev-tunnels SDK 0.1.13 to 0.1.19 by [@​sam-byng](https://github.com/sam-byng) in [#​12285](cli/cli#12285) #### New Contributors - [@​ferhatelmas](https://github.com/ferhatelmas) made their first contribution in [#​12234](cli/cli#12234) - [@​sam-byng](https://github.com/sam-byng) made their first contribution in [#​12285](cli/cli#12285) **Full Changelog**: <cli/cli@v2.83.1...v2.83.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi40Ny4wIiwidXBkYXRlZEluVmVyIjoiNDIuNDcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I ran
make licensesit deleted all my licenses. The script is supposed to installgo-licensesbut I didn't have the installation location on my path. Better to just exit.Potentially we could gate the
go install, but I chose not to because I'm happy for it to keep updating me tolatestwhen I run this script.