Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Isolate remaining old-style commands #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 12, 2020
Merged

Isolate remaining old-style commands #1500

merged 13 commits into from
Aug 12, 2020

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Aug 7, 2020 •
edited
Loading

Isolated issue and other remaining commands to their own packages. This resulted in a major cleanup in the old command/root.go and context package. 🤘

Fixes #759

TODO:

  • port over alias commands and we're done!

@mislav mislav requested a review from vilmibm August 7, 2020 15:00
vilmibm
vilmibm approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for all this ;_;

Base automatically changed from pr-commands-isolate-3 to trunk August 11, 2020 13:40
@mislav mislav requested a review from vilmibm August 11, 2020 13:42
@mislav
Copy link
Contributor Author

mislav commented Aug 11, 2020

@vilmibm I've also ported alias commands and expansion since you've last reviewed. Please take a look!

Note that additional auth commands are now to be added in pkg/cmd/auth/auth.go instead of to command/root.go

vilmibm
vilmibm approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias port looks great and i'm excited for the root reorganization

@mislav mislav merged commit 291cded into trunk Aug 12, 2020
@mislav mislav deleted the issue-commands-isolate branch August 12, 2020 10:35
@mislav mislav mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vilmibm vilmibm vilmibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve test isolation when exercising Cobra commands

4 participants

@mislav @vilmibm @neso123456