Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Interactive template selection test for issue create #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

Interactive template selection test for issue create #1582

merged 3 commits into from
Sep 8, 2020

Conversation

@AliabbasMerchant
Copy link
Contributor

Fixes #956
Replaces #1311

Thanks to the refactor, this has become quite simple.

@AliabbasMerchant
Copy link
Contributor Author

Have made changes in issue create currently and have written a sample test for the same.
Will add for pr create once this approach gets approved

@AliabbasMerchant AliabbasMerchant mentioned this pull request Aug 27, 2020
Closed
vilmibm
vilmibm approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm happy with this approach. Did you want to add the PR version in this PR or a followup?

@AliabbasMerchant
Copy link
Contributor Author

👍 I will add it in this PR itself

@vilmibm
Copy link
Contributor

vilmibm commented Sep 8, 2020

thanks so much!

@vilmibm vilmibm merged commit c2d7cbf into cli:trunk Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vilmibm vilmibm Awaiting requested review from vilmibm

1 more reviewer

@T1ADIPT4 T1ADIPT4 T1ADIPT4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make template selection test-able

4 participants

@AliabbasMerchant @vilmibm @T1ADIPT4 @Dodgeqtr