Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Be transparent about which part of pr create flow failed #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Be transparent about which part of pr create flow failed #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/queries_pr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ func CreatePullRequest(client *Client, repo *Repository, params map[string]inter
}
err := client.GraphQL(repo.RepoHost(), updateQuery, variables, &result)
if err != nil {
return nil, err
return pr, err
}
}

Expand All @@ -708,7 +708,7 @@ func CreatePullRequest(client *Client, repo *Repository, params map[string]inter
}
err := client.GraphQL(repo.RepoHost(), reviewQuery, variables, &result)
if err != nil {
return nil, err
return pr, err
}
}

Expand Down
10 changes: 7 additions & 3 deletions pkg/cmd/pr/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,15 @@ func createRun(opts *CreateOptions) error {
}

pr, err := api.CreatePullRequest(client, baseRepo, params)
if pr != nil {
fmt.Fprintln(opts.IO.Out, pr.URL)
}
if err != nil {
return fmt.Errorf("failed to create pull request: %w", err)
if pr != nil {
return fmt.Errorf("pull request update failed: %w", err)
}
return fmt.Errorf("pull request create failed: %w", err)
}

fmt.Fprintln(opts.IO.Out, pr.URL)
} else if action == shared.PreviewAction {
openURL, err := generateCompareURL(baseRepo, baseBranch, headBranchLabel, title, body, tb.Assignees, tb.Labels, tb.Projects, tb.Milestones)
if err != nil {
Expand Down