-
Notifications
You must be signed in to change notification settings - Fork 7.3k
linux repository automation #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- deb and rpm packages are now built for prereleases - consolidate setup for deb & rpm - man pages are generated for prereleases - the `cli.github.com` site is only pushed to on full releases Bonus: - only publish the GitHub release after the Windows MSI is uploaded - hub does not need downloading
Our tap is now deprecated in favor of `gh` from homebrew-core
- Move all Linux installation docs to the separate page to eliminate repetition - Indicate that only Ubuntu 20.04 is supported for apt-add-repository method - Pull openSUSE/SUSE out of the "unofficial" section since it refers to downloading our official packages - Point out manual installation methods as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the hard work, @vilmibm!
I have pushed some updates:
-
Deb & RPM packages are now published as part of the main
goreleaserjob. This allows us to consolidate the duplication in setup (primarily around GPG). -
The
i3h/download-release-assetdependency is eliminated. Adding a 3rd-party Action to our release workflow is risky because it could modify our binaries, and also the action was configured to download the binaries from thelatestRelease tag, which might not necessarily match the actual git tag being pushed. -
We now only push to our Pages site once instead of 3 times (man pages + deb + rpm). This eliminates the potential race condition where
rpm-reposanddeb-reposjobs running in parallel could potentially try to push to the site at the same time. -
Most of our release workflow is now exercised for pre-releases, except:
- The Pages site gets updated locally, but never published;
- Projects cards are queried, but never actually moved.
-
The final Release is only published after the MSI file gets uploaded. Before, Windows users could potentially get informed about a new release before the MSI installer becomes available.
-
I have moved all Linux installation instructions to the separate doc to avoid duplication and make community contributions easier. I have also added a hint to Ubuntu installation instructions that only Ubuntu 20.04 is currently supported from our sources.
|
Just installed the Debian package and found the executable at |
Proper Linux Repositories
This PR adds automation and documentation around
debandrpmpackage repositories forgh. The repositories already exist and contain 0.11.1; the next release will use this automation to add 0.12.0 to the repositories.I chose to add two new workflows that depend on the
goreleaserflow. It means there are redundant steps across the three flows but I wanted fault isolation and easier debuggability.I also did something we've discussed which was pushing "unsupported" linux install methods into their own document; I'd appreciate feedback on the wording used there.
if you want to test this on either debian stable or ubuntu 20.04:
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-key C99B11DEB97541F0 && sudo apt-add-repository -u https://cli.github.com/packages && sudo apt install ghTo test on Fedora or similar:
sudo dnf config-manager --add-repo https://cli.github.com/packages/rpm/gh-cli.repo && dnf install ghcloses #1216
closes #834
closes #448
TODONE
focalsupported instead of juststable(this will allow add-apt-repository to work on ubuntu)add-apt-repository -k pgp.mit.edureleases.ymlwith appropriate prerelease guards