Fix detecting display width of common punctuation characters #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These characters get classified as "East Asian Mixed" by Go's `text/width` package, and thus assumed that their printed version occupies a width of 2 characters, whereas they each only occupy one. I'm not sure why they are classified as East Asian, but I did not have the energy to dive into Go's Unicode tables, so here is a workaround based on an exclusion list.
|
ah, I guess this is why the dot was messing up formatting when I tried to use it in pr checks. We can switch to that it in the future, then. Thanks for the investigation. |
vilmibm
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These characters get classified as "EastAsianAmbiguous" by Go's
text/widthpackage, and thus assumed that their printed version occupies a width of 2 characters, whereas they each only occupy one.I'm not sure why they are classified as East Asian, but I did not have the energy to dive into Go's Unicode tables, so here is a workaround based on an exclusion list.
This affects all TablePrinter output, therefore commands such as
issue/pr list.