Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Filter gh credits for humans #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2020
Merged

Filter gh credits for humans #1623

merged 1 commit into from
Sep 7, 2020

Conversation

@bdougie
Copy link
Contributor

@bdougie bdougie commented Sep 4, 2020 •
edited
Loading

What is this?

The top maintainers on my project are dependabot-preview[bot] and gh-action[bot]. I am opening this PR in response to #1597.

Solution

I added another condition to leave out logins that are not humans (Users).

I ran the test in a Codespace and they passed, let me know if a new test is needed for this condition.

Screen Shot 2020-09-04 at 8 19 57 AM

Screenshot

no bots

Screen Shot 2020-09-04 at 9 10 07 AM

@bdougie bdougie changed the title Filter credit bots Filter gh credits humans Sep 4, 2020
@bdougie bdougie changed the title Filter gh credits humans Filter gh credits for humans Sep 4, 2020
mislav
mislav suggested changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it; thanks for this! Spotted one bug in non-default mode

@bdougie bdougie force-pushed the bdougie-filter-credit-bots branch from dcf52c1 to 52985b7 Compare September 7, 2020 05:00
@bdougie bdougie force-pushed the bdougie-filter-credit-bots branch from 52985b7 to d83c99f Compare September 7, 2020 05:02
mislav
mislav approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@mislav mislav merged commit 5e11fe8 into cli:trunk Sep 7, 2020
@vilmibm vilmibm mentioned this pull request Sep 16, 2020
Closed
@bdougie bdougie mentioned this pull request Jul 25, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdougie @mislav