Extend PAGER support to all commands producing significant output #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the ad-hoc PAGER behavior from `pr diff` command and make it available opt-in to any command through IOStreams.
Nutza97
approved these changes
Sep 7, 2020
samcoe
approved these changes
Sep 11, 2020
Unset PAGER environment variable when executing the command referenced in PAGER in case that command also has support for PAGER and would end up executing itself indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pr diffcommand had explicit support for defining a pager program through the PAGER environment variable. This tweaks that implementation to make it globally available to commands through the IOStreams object.Example use:
PAGER=less gh repo view cli/cliAffected commands:
repo viewissue/pr viewissue/pr listissue/pr statusRef. #1100
Followup to #1290
TODO:
gh config set pager ...?gh apicommand?