My understanding was that --web was never intended to prevent all prompting; it was just one of multiple flags you could pass to affect prompting. @ampinsk could you help clarify?

The --web flag was intended to help skip the "How would you like to authenticate?" prompt, not necessarily in itself skipping all prompts.

However, if the user passes both the --hostname flag and the --web flag, I think we could assume that we should skip everything else (similar to what we do with gh pr create -t "title" -b "body").

Going through @mislav's points:

If an authentication token exists and it's valid, there will be a prompt “Do you want to re-authenticate?”

I suggest that we simply exit at this point without prompting, and pointing the user to gh auth refresh if they want to rotate their credentials.

👍 This makes sense to me as the behavior when both --web and --hostname are passed.

The “Choose default git protocol” prompt follows successful authentication. Should this prompt still be active in --web mode?

Let's skip this if both --web and --hostname are passed.

Does that make sense? Apologies for the lack of clarity in the original issue! 🙇‍♀️

Updated along the lines of @mislav 's feedback after discussing with @ampinsk and playing around in the terminal; this is ready for re-review now.

I chose to be explicit about setting the git_protocol value so that a user gets a hint about how to change it if they desire ssh.

It looks to be resetting my git_protocol each time I run this cmd. Please verify as I start out with ssh then after running the new cmd, it resets to https.

➜  cli git:(web-flag) ✗ bin/gh config get -h github.com git_protocol
ssh
➜  cli git:(web-flag) ✗ bin/gh auth login -w
- Logging into github.com

! First copy your one-time code: 1DB4-04CF
- Press Enter to open github.com in your browser...
✓ Authentication complete. Press Enter to continue...

- gh config set -h github.com git_protocol https
✓ Configured git protocol
✓ Logged in as tierninho
➜  cli git:(web-flag) ✗ bin/gh config get -h github.com git_protocol
https