Fix issue listing misalignment #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b450e3 to
939bf01
Compare
939bf01 to
e5466c0
Compare
mislav
approved these changes
Sep 11, 2020
|
@mislav For emoji that are composed of multiple runes we now iterate through the runes and choose the display width for the first non-zero width rune and assume that the emoji is that width. Previously we would just be counting the display width of all the runes in the emoji. For example: Emoji String: 🇪🇷 This should work fine for most cases, but if we are alerted to any emoji that don't fit that algorithm we can special case them in the code without much difficulty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logic for determining string truncation and string display width. This new logic uses a combination of https://github.com/mattn/go-runewidth and https://github.com/rivo/uniseg. This should result in better alignment when using the issue list command.
Note:
func graphemeWidthis not always 100% accurate so there might still be some misalignment cases that exist but it has more robust rune recognition (due to go-runewidth) than our previous implementation.closes #1454