Use text/template instead of http/template. #1671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http/tempate results in html -unsafe characters (e.g. angle brackets, quotes, etc) being escaped e.g. ``` gh repo view cli/cli ... ## We want your feedback We&cli#39;d love to hear your feedback about gh . If you spot bugs or have features that you&cli#39;d really like to see in gh , please check out the contributing page ... ``` Note that "We&cli#39;d" instead of "We'd".
|
thank you! i think this is a dupe of #1657 , unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http/tempate results in html -unsafe characters like angle brackets, quotes, etc being escaped e.g.
Note that
We'dandyou'd.This affected only standard terminals, for which an HTML template renderer was used.