Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Extract environment variables as a separate help topic #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2020
Merged

Extract environment variables as a separate help topic #1696

merged 4 commits into from
Sep 15, 2020

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Sep 14, 2020

Running gh (without arguments) or gh help now prints:

ENVIRONMENT VARIABLES
  See 'gh help environment' for the list of supported environment variables.

The new gh help environment topic now prints the list of all available environment variables.

Fixes #1384
Supersedes #1690

@samcoe samcoe self-assigned this Sep 14, 2020
@samcoe samcoe mentioned this pull request Sep 14, 2020
Closed
ampinsk
ampinsk approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@ampinsk ampinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh help looks so much cleaner! 🎉

mislav
mislav commented Sep 15, 2020
View reviewed changes
Copy link
Contributor Author

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new approach with SetHelpFunc(), @samcoe! Really good thinking.

vilmibm
vilmibm approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a really cool approach! thanks y'all!

@vilmibm vilmibm added the docs label Sep 15, 2020
@samcoe samcoe merged commit 4933fd9 into trunk Sep 15, 2020
@samcoe samcoe deleted the env-help-topic branch September 15, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@vilmibm vilmibm vilmibm approved these changes

@samcoe samcoe samcoe approved these changes

@ampinsk ampinsk ampinsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samcoe samcoe

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract docs about supported environment variables into its own help page

4 participants

@mislav @vilmibm @samcoe @ampinsk