-
Couldn't load subscription status.
- Fork 7.3k
bunch of gist stuff #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bunch of gist stuff #1699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I love the editing functionality.
| if len(gists) == limit { | ||
| break | ||
| } | ||
| if visibility == "all" || (visibility == "secret" && !gist.Public) || (visibility == "public" && gist.Public) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With GraphQL, I think you might be able to fetch gists based on their private bit and order them by UPDATED_AT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah interesting, for some reason my brain thought "gists are not in the graphql api" but there they are.
i'm going to finish writing tests and then if i have time circle back and port this to graphql.
|
Just a few thoughts after playing around with this:
|
I don't see any public gists at https://gist.github.com/tierninho ; do you have secret gists? I think if a user has no gists we should probably print a user friendly message.
I don't think there is anything wrong here. There is a gist with a hardcoded id of 1 with that "poem" (it's a joke version of the marine corps Rifle Creed) and you fetched it with
They are added to your gists at https://gist.github.com/tierninho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Ship it, ship it to the moon! 🚀 🌔
This is all that’s still needed in order to be able to use |
👍
Yes, I was taken to a random page that said this user has no gists. It went here: (https://gist.github.com/1). |
more gist
video demo!
This PR:
gh gist list --publicgh gist list --secretgh gist list --limit 2gh gist edit --filename foo.txtedit just one specific file in the gistgh gist view --web eb834408ca7ffc9c5e7fb15b0e7d25c4open gist in browsergh gist view --raw eb834408ca7ffc9c5e7fb15b0e7d25c4do not attempt to render markdown if foundgh gist view --filename foo.txtonly printfoo.txtgh gist createto allow you to name files added via stdingh alias listto output yaml alwaysgh gistto add it to core commandsLimitations
listonly deals with current authenticated user's gists (but view can view other users' gists)