Fallback browser when xdg-open does not exist
#1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
suggested changes
Sep 16, 2020
xdg-open does not exist
a0fe882 to
9d346ef
Compare
9d346ef to
dd1c24a
Compare
mislav
suggested changes
Sep 16, 2020
mislav
suggested changes
Sep 16, 2020
mislav
approved these changes
Sep 16, 2020
|
Nice fix! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #826
Details
Look at/proc/sys/kernel/osreleaseto determine ifghis running inside WSL2. WSL1 detection is more complicated and not deterministic, so for now we will only detect WSL2.Provide a way to positively detect WSL from an app compiled on Linux. microsoft/WSL#423 (comment)If in WSL2 then usewslviewinstead ofxdg-openwhich is not available in WSL2xdg-openexists inPATHand if not fallback to usingwslview.