♻️ Refactor gist list to use graphQL #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Gleich <[email protected]>
mislav
suggested changes
Sep 18, 2020
|
Yep. I was looking into it yesterday and I'll try to get it working. Haven't really worked with the testing side of things with graphql before so I might need a little help. |
Signed-off-by: Matthew Gleich <[email protected]>
Signed-off-by: Matthew Gleich <[email protected]>
It's not sufficient to use `Changed("public")` to test if a boolean flag
was activated, since the user might have passed `--public=false`.
Instead, check the true value of the flag.
The `--public` and `--secret` flags should be mutually exclusive, so now
if both are activated, `--secret` takes precedence.
- Fetching more than 100 gists is now supported - The GraphQL query name is now `GistList` instead of `ListGists` for consistency with other queries - Avoid fetching unnecessary Files fields - Gists are now rendered in the order that the API returned them in - The gist timestamp for machine-readable output is now rendered in RFC3339 format instead of in `time.Time.String()` format which is only meant for debugging and is not considered stable - Ensure newlines in gist description are rendered as spaces
mislav
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
@Matt-Gleich Thanks for the updates!
@vilmibm I've added a number of changes to this branch:
- Ported the GraphQL query to "githubv4" adapter
- Fetching more than 100 gists is now supported
- The GraphQL query name is now
GistListinstead ofListGistsfor consistency with other queries - Avoid fetching unnecessary Files fields
- Gists are now rendered in the order that the API returned them in (CreatedAt desc) instead of reordered by UpdatedAt timestamp - should we consider displaying the CreatedAt timestamp instead of UpdatedAt?
- The gist timestamp for machine-readable output is now rendered in RFC3339 format instead of in
time.Time.String()format which is only meant for debugging and is not considered stable - Ensure newlines in gist description are rendered as spaces
- It's not sufficient to use
Changed("public")to test if a boolean flag was activated, since the user might have passed--public=false. Instead, check the true value of the flag. - The
--publicand--secretflags should be mutually exclusive, so now if both are activated,--secrettakes precedence.
vilmibm
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1712.