fix create.go to take repo name from prompt #1780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilmibm
suggested changes
Sep 18, 2020
samcoe
suggested changes
Sep 21, 2020
There was a problem hiding this comment.
Thanks for attempting to fixing this bug!
This solution incorrectly handles one use case though. When providing an argument to gh repo create that is in the format of owner/repo or host/owner/repo we skip parsing the name which will result in the incorrect repository name and local directories being created.
Current behavior:
Pull request behavior:
I created another PR #1880 that I think should properly handle all the cases.
|
no apologies needed @iamadarshk <3 for posterity, closed by #1880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1768