Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Sep 19, 2020

By doing this, the command will finish faster if the user canceled the editing.

By doing this, the command will finish faster if the user canceled
the editing.
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! The fix looks good, but I'm not sure if the added tests asserts that no API update has happened? It feels to me like the added tests might have had passed without the fix as well.

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vilmibm vilmibm merged commit 2a9b5de into cli:trunk Sep 21, 2020
@vilmibm
Copy link
Contributor

vilmibm commented Sep 21, 2020

@mislav the test will fail if a POST is made which I think is good enough, here.

@y-yagi y-yagi deleted the do-not-send-requests-when-unnecessary branch September 22, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants