Check for terminal background color before starting pager #1917
Conversation
1db9152 to
383a903
Compare
383a903 to
ed40755
Compare
pkg/iostreams/iostreams.go
Outdated
| func (s *IOStreams) ResolveBgColor() string { | ||
| style := os.Getenv("GLAMOUR_STYLE") | ||
| if (!s.ColorEnabled()) || | ||
| (style != "" && style != "auto") || |
There was a problem hiding this comment.
I looks like there are now two separate packages that independently look up GLAMOUR_STYLE and compare it to "auto". Could this be consolidated?
There was a problem hiding this comment.
Yeah I agree. This was my biggest issue with this approach. If GLAMOUR_STYLE is set we don't want to actually detect the terminal background color because we are not going to use those results, but right now we are throwing away what the GLAMOUR_STYLE is set to. I thought about setting BgColor to be GLAMOUR_STYLE which would save use from having to do it in the markdown package but then the naming felt wrong since it is not actually the BgColor. Which is how I ended up doing the check twice. I am happy to move in the direction I outlined above, or if there are better ideas I am open to hearing them.
11ef875 to
f0d4fbf
Compare
4e06ede to
8f27cb3
Compare
This PR fixes the bug where determining the terminal background color for markdown rendering was causing a weird interaction with
PAGER. Now we will resolve the terminal background color before startingPAGER. Resolving the terminal background is a no-op if we are not outputting to TTY, the pager has already be started, or theGLAMOUR_STYLEenvironment variable is set to something other thanauto.closes #1822
cc #1930