Comment on issues from editor #2008
Conversation
| @@ -0,0 +1,117 @@ | |||
| package comment | |||
There was a problem hiding this comment.
will add more tests
|
Thanks for this! As per our CONTRIBUTING docs we prefer it if people check in with us about adding features not marked as That said, this is a valid approach and one we were considering; we'd just like to take the time to ensure this is the direction we want to go in with commenting. You've done good work and we will circle back to this PR once we've had a chance to discuss internally. cc @ampinsk |
|
@vilmibm I am sorry that I missed the |
This comment has been minimized.
This comment has been minimized.
|
@Yuuki77 Thank you for your contribution! At a quick glance, the code looks pretty solid to me. My apologies about the confusion about whether we want to accept outside contributions for this feature. At the time that you opened this PR, we haven't decided on that yet. Starting from this week, we are starting development of this feature, and your PR is going to be considered and potentially incorporated in our work. Please have patience with us while we figure out exactly how we want the commands and flags to be named. 🙇 |
|
@li-maisiliym-xyz We generally try to welcome constructive criticism of our code or practices, but I can't see how your criticism is constructive. Your tone sounds hostile to our developers, and I've hidden it per the "insulting/derogatory comments" clause of our Code of Conduct. |
|
@mislav Thank you for the updates! 😄 |
Fix #517
It is now possible to comment on an issue from the editor.
gh issue comment <url> or <issue number>How to test
1 . create a issue
2.` gh comment issue
3 add the body from editor
4 submit the comment
5 test same for url
6 please test if
gh comment issue <issue number> -b "your comment"work as well7. please check if the cancel works as well.
This is my first pr to this repo. If you have any comments, please let me know 😄