Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Filter out unwanted stderr output during git push commands #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2020
Merged

Filter out unwanted stderr output during git push commands #2016

merged 6 commits into from
Nov 3, 2020

Conversation

@samcoe
Copy link
Contributor

@samcoe samcoe commented Sep 29, 2020 •
edited
Loading

This PR creates a wrapper around an io.Writer type that will filter the output based on a regex and replace matches with a replacement string, and finally write the filtered output to the original io.Writer.

closes #1067

@samcoe samcoe self-assigned this Sep 29, 2020
@samcoe samcoe force-pushed the filter-git-push-output branch 6 times, most recently from 1a414cf to a90a9a0 Compare September 30, 2020 11:06
@samcoe samcoe changed the title WIP Filter out unwanted stderr output during git push commands Sep 30, 2020
@samcoe samcoe force-pushed the filter-git-push-output branch from a90a9a0 to 4100857 Compare September 30, 2020 11:13
samcoe
samcoe commented Sep 30, 2020
View reviewed changes
samcoe
samcoe commented Sep 30, 2020
View reviewed changes
samcoe
samcoe commented Sep 30, 2020
View reviewed changes
@samcoe samcoe requested a review from a team September 30, 2020 11:18
@samcoe samcoe marked this pull request as ready for review September 30, 2020 11:18
mislav
mislav suggested changes Sep 30, 2020
View reviewed changes
@samcoe samcoe force-pushed the filter-git-push-output branch from 4100857 to c138964 Compare October 1, 2020 07:16
@samcoe samcoe requested a review from mislav October 1, 2020 08:18
@samcoe samcoe force-pushed the filter-git-push-output branch from 514b202 to e30be98 Compare October 1, 2020 08:22
mislav
mislav previously requested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is progressing great! I would suggest focusing on ironing out the RegexWriter so it doesn't inadvertently change the output that wasn't related to "Create a pull request", such as the progress indicator from git push.

@samcoe samcoe requested a review from mislav October 5, 2020 07:05
@samcoe samcoe force-pushed the filter-git-push-output branch 2 times, most recently from b44ce6d to 901ac02 Compare October 7, 2020 12:24
cbraynor
cbraynor reviewed Oct 12, 2020
View reviewed changes
@samcoe samcoe force-pushed the filter-git-push-output branch 5 times, most recently from fb7b594 to b1672d8 Compare October 20, 2020 06:40
vilmibm
vilmibm approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm into this 👍 sam had expressed concern about it being over-complex and perhaps for this single use case it is, but once it exists I definitely see us reaching for it more to handle git output.

I'd like to have it in; and it's easy to remove and do something simpler if we decide we want that.

@vilmibm vilmibm dismissed mislav’s stale review November 2, 2020 23:12

the feedback was addressed and mislav is OOO

@samcoe samcoe force-pushed the filter-git-push-output branch from b1672d8 to 9acbf8a Compare November 3, 2020 06:59
@samcoe samcoe merged commit 72ec5be into trunk Nov 3, 2020
@samcoe samcoe deleted the filter-git-push-output branch November 3, 2020 07:05
@mislav mislav mentioned this pull request Apr 23, 2021
Closed
@samcoe samcoe mentioned this pull request May 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mislav mislav Awaiting requested review from mislav

2 more reviewers

@cbraynor cbraynor cbraynor left review comments

@vilmibm vilmibm vilmibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samcoe samcoe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Create a pull request for branchname on GitHub by visiting" is unneeded log junk

4 participants

@samcoe @mislav @vilmibm @cbraynor