Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check gist ownership before editing #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2020
Merged

Check gist ownership before editing #2034

merged 2 commits into from
Oct 5, 2020

Conversation

@cristiand391
Copy link
Contributor

Fix #1966

ErKiran
ErKiran reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ErKiran ErKiran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to use id instead of Login property?

username, err := api.CurrentLoginName(apiClient, ghinstance.OverridableDefault())
	if err != nil {
		return err
	}
	if username != gist.Owner.Login {
		return fmt.Errorf("You do not own this gist.")
	}

Use the id property of the owner and compare it with api.CurrentUserID(apiClient, hostname)

@hmoooda

This comment has been minimized.

Sign in to view
@vilmibm vilmibm self-requested a review October 5, 2020 16:01
vilmibm
vilmibm approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, thank you!

@vilmibm vilmibm merged commit 14a5e00 into cli:trunk Oct 5, 2020
@cristiand391 cristiand391 deleted the check-gist-ownership branch October 5, 2020 22:09
Mercadojale
Mercadojale reviewed Oct 14, 2020
View reviewed changes
Copy link

@Mercadojale Mercadojale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@ErKiran ErKiran ErKiran left review comments

@Mercadojale Mercadojale Mercadojale left review comments

@vilmibm vilmibm vilmibm approved these changes

@Rodrigo390 Rodrigo390 Rodrigo390 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gist: edit command doesn't check gist ownership before editing

6 participants

@cristiand391 @hmoooda @vilmibm @ErKiran @Mercadojale @Rodrigo390