Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add int32 validation to milestone numbers #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add int32 validation to milestone numbers #2178

merged 1 commit into from
Oct 20, 2020

Conversation

@quiye
Copy link
Contributor

@quiye quiye commented Oct 12, 2020

Fixes #2154

The 32-bit version of ParseInt makes it easy to verify if milestoneString is a 32-bit integer or not.

If the input number is valid for int32, it will be used as an intergar milestone.
Prior to this patch, int64 was used for integer validation.

$ make
$ DEBUG=api ./bin/gh issue list -m 2147483647 2>&1 | grep '"number"'
        "number": 2147483647,
$ DEBUG=api ./bin/gh issue list -m 2147483648 2>&1 | grep '"number"'
$

mislav
mislav approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for the fix

@samcoe samcoe merged commit 869f511 into cli:trunk Oct 20, 2020
@quiye quiye deleted the milestone-int32-validation branch October 24, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mislav mislav mislav approved these changes

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integer overflow occured at gh issue list --milestone

3 participants

@quiye @mislav @samcoe