Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Codespaces] Support "integration" tokens #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2020
Merged

[Codespaces] Support "integration" tokens #2207

merged 5 commits into from
Oct 27, 2020

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Oct 16, 2020 •
edited
Loading

  • Skip checking OAuth scopes for "integration" tokens - the X-Oauth-Scopes response header will either be missing or blank
  • Fix formatting in error message reporting missing OAuth scopes
  • Fix printing token source in gh auth status when scopes are missing
  • Add tests for HasMinimumScopes
  • Remove obsolete CheckScopes implementation
  • Disable update notifier when running under Codespaces
codespace:~/workspace/cli$ make && bin/gh auth status
github.com
  ✓ Logged in to github.com as mislav (GITHUB_TOKEN)
  ✓ Git operations for github.com configured to use https protocol.

Fixes #1489, closes #1074

samcoe
samcoe approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I like the clean up of the old CheckScopes implementation.

@mislav mislav requested a review from vilmibm October 20, 2020 14:38
@samcoe samcoe merged commit edecb2e into trunk Oct 27, 2020
@samcoe samcoe deleted the codespaces branch October 27, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vilmibm vilmibm Awaiting requested review from vilmibm

1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support GitHub Apps integration tokens as means of authentication Support VSCode builtin GitHub authentication

2 participants

@mislav @samcoe